Skip to content

Sockets - Jansen#10

Open
JansenMartin wants to merge 1 commit intoAda-C11:masterfrom
JansenMartin:master
Open

Sockets - Jansen#10
JansenMartin wants to merge 1 commit intoAda-C11:masterfrom
JansenMartin:master

Conversation

@JansenMartin
Copy link
Copy Markdown

No description provided.

Comment thread lib/array_intersection.rb
return [] if array1 == nil || array2 == nil

# Figure out which array is longer (so longest will be sorted)
# (If they're the same, array1 will be sorted)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great comment here.

Comment thread lib/array_intersection.rb
i += 1
end

# For each element in smaller array, perform binary search in sorted array
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice re-use of your binary search from previous homework. 👍

Comment thread lib/array_intersection.rb
end
end

return results
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants